From 665addd610a9dedd5051d1e6bd41dbe485945828 Mon Sep 17 00:00:00 2001 From: PiliLily Date: Sun, 23 Aug 2026 14:33:44 +0800 Subject: [PATCH] sched: make three file-local helpers static __pick_next_task_bt() in kernel/sched/batch.c, llc_get_task() in kernel/sched/fair.c and may_kick_sibling() in kernel/sched/ht_isolate.c are referenced only inside their own implementation files and have no declaration in any header. A W=1 build with the OpenCloudOS distro configuration therefore reports a -Wmissing-prototypes warning for each of them. Mark the three helpers static to give them internal linkage. This fixes the warnings without changing runtime behavior. A targeted W=1 rebuild of kernel/sched confirms the three warnings are gone and no new warning appears. Upstream status: downstream-only Signed-off-by: PiliLily --- kernel/sched/batch.c | 2 +- kernel/sched/fair.c | 4 ++-- kernel/sched/ht_isolate.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/sched/batch.c b/kernel/sched/batch.c index 8d0501fa056c..2915775142a2 100644 --- a/kernel/sched/batch.c +++ b/kernel/sched/batch.c @@ -160,7 +160,7 @@ struct task_struct *pick_next_task_bt(struct rq *rq, struct task_struct *prev, s return NULL; } -struct task_struct *__pick_next_task_bt(struct rq *rq, struct task_struct *prev) +static struct task_struct *__pick_next_task_bt(struct rq *rq, struct task_struct *prev) { return pick_next_task_bt(rq, prev, NULL); } diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 45cd9f305a3b..23d2031bac96 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -10228,8 +10228,8 @@ llc_detach_next_task(struct cfs_rq *cfs_rq, struct rq *dst_rq) return NULL; } -int llc_get_task(struct rq *dst_rq, struct rq_flags *dst_rf, - bool *locked, int src_cpu) +static int llc_get_task(struct rq *dst_rq, struct rq_flags *dst_rf, + bool *locked, int src_cpu) { struct task_struct *p = NULL; struct rq_flags rf; diff --git a/kernel/sched/ht_isolate.c b/kernel/sched/ht_isolate.c index f8d6709ec7c7..384230da201e 100644 --- a/kernel/sched/ht_isolate.c +++ b/kernel/sched/ht_isolate.c @@ -4,7 +4,7 @@ int sysctl_ht_isolate; -bool may_kick_sibling(int cpu) +static bool may_kick_sibling(int cpu) { struct rq *rq = cpu_rq(cpu); return rq->ht_sensi_type == HT_SENSITIV_TYPE ? true : false; -- Gitee