tkernel: netatop: fix W=1 warnings and add SPDX identifiers · Pull Request !977 · OpenCloudOS/OpenCloudOS-Kernel

## Problem

Building kernel/tkernel/netatop/ with W=1 reports eight
-Wold-style-definition warnings: gctaskexit(), gcsockinfo(),
gctaskinfo(), wipesockinfo(), wipetaskinfo(), wipetaskexit(),
init_module() and cleanup_module() all declare their parameter
list as () while the forward declarations in the same file
(lines 313-320) already use (void).

netatop.c, netatop.h and netatopversion.h also lack SPDX
license identifiers.

## Root Cause

The file originates from the atop project and predates the
kernel-wide SPDX conversion; the definitions were never aligned
with the (void) style of their own forward declarations.

## Fix

- Change the eight definitions from () to (void).
- Replace strncpy(tip->command, current->comm, COMLEN) in
  gettaskinfo() with strscpy() and sizeof(tip->command) so the
  destination size and the source bound cannot drift apart.
- Add SPDX-License-Identifier: GPL-2.0 as line 1 of netatop.c
  and netatopversion.h, netatop.h (GPL v2 per the file header
  and MODULE_LICENSE("GPL")).

The gc/wipe functions are untouched by open PRs #964/#966
(they modify init_module()/cleanup_module() error paths); the
two-line overlap there is the parameter list only.

## Testing

- make W=1 kernel/tkernel/netatop/ after touching netatop.c:
  0 warnings (baseline before change: 8).
- make M=kernel/tkernel/netatop modules: netatop.ko links.
- scripts/checkpatch.pl --terse --no-tree: 0 errors.
- make dist-check-commit: PASS.

Upstream status: downstream-only

## Risk

Low: parameter-list and string-copy cleanup only, no behaviour
change; strscpy truncation semantics match the old bounded
strncpy for a 16-byte comm field.

类型	指派人员	状态
审查	zoucao Huang Cun Jianping Liu	已完成 (0/0人)
测试	Jianping Liu	已完成 (0/0人)

GVPOpenCloudOS / OpenCloudOS-Kernel

搜索帮助

GVP OpenCloudOS / OpenCloudOS-Kernel