tkernel: onionhook: declare data_release in hook_frame.h · Pull Request !980 · OpenCloudOS/OpenCloudOS-Kernel

## Problem

Building kernel/tkernel/onionhook/ with W=1 reports
"no previous prototype for 'data_release'" because the only
declaration of this EXPORT_SYMBOL'd function lives in the aegis
private header kernel/tkernel/aegis/list.h:8 instead of in
include/linux/hook_frame.h, which owns the rest of the
onionhook interface.

## Root Cause

The declaration was placed in the consumer's private header
when the hook framework was introduced; the provider header
was never updated, so every W=1 build of the provider flags
the missing prototype.  The dependency is inverted:

before (wrong)                     after (this patch)
    ----------------------            ----------------------
    onionhook/hook_frame.c            onionhook/hook_frame.c
      defines + EXPORTs                 defines + EXPORTs
             ^                                  ^
             | calls                           | calls
    aegis/hook_info.c                  aegis/hook_frame.h  <- declares
             ^                                  ^
             | includes                         | includes
    aegis/list.h  <- declares           aegis/hook_info.c

The only prototype lived in the consumer's private header,
so the provider compiled without any visible prototype
(W=1 missing-prototypes) and a future signature change
could not be caught at compile time.

## Fix

Declare data_release() in include/linux/hook_frame.h next to
the other onionhook exports, add <linux/kref.h> (the new
declaration takes a struct kref *) and the missing SPDX
identifier.  The aegis-local declaration is left untouched to
avoid conflicting with the four aegis PRs currently in flight.

## Testing

- make W=1 kernel/tkernel/onionhook/ after removing
  hook_frame.o: 0 warnings (baseline: 1 missing-prototypes).
- Dependent aegis build (hook_info.o includes both headers):
  recompiled clean, 0 errors.
- Full tkernel kselftest suite in QEMU on a bzImage rebuilt
  with this header change: OVERALL PASS.
- scripts/checkpatch.pl --terse --no-tree: 0 errors.
- make dist-check-commit: PASS.

Upstream status: downstream-only

## Risk

Low: header-only addition of a declaration that already exists
verbatim in aegis/list.h; no code generation change, no ABI
change.

## Future

Once the four in-flight aegis PRs (#960 #961 #965 #968) have
landed, the duplicate extern declaration in
kernel/tkernel/aegis/list.h:8 should be removed so that
hook_frame.h remains the single source of truth; aegis
compiles fine without it since hook_info.c already includes
hook_frame.h.

类型	指派人员	状态
审查	zoucao Huang Cun Jianping Liu	已完成 (0/0人)
测试	Jianping Liu	已完成 (0/0人)

GVPOpenCloudOS / OpenCloudOS-Kernel

搜索帮助

GVP OpenCloudOS / OpenCloudOS-Kernel